commit d72103d9605a775f8ddfc45f5dbf878ca54b9327
Author: Wim <wim@42.be>
Date: Thu Nov 08 00:46:34 2018 +0000
Make gocritic linter happy
diff --git a/bridge/discord/discord.go b/bridge/discord/discord.go
index 0549187..94a0918 100644
--- a/bridge/discord/discord.go
+++ b/bridge/discord/discord.go
@@ -2347 +2347 @@ func (b *Bdiscord) messageUpdate(s *discordgo.Session, m *discordgo.MessageUpdat
// only when message is actually edited
if m.Message.EditedTimestamp != "" {
b.Log.Debugf("Sending edit message")
- m.Content = m.Content + b.GetString("EditSuffix")
+ m.Content += b.GetString("EditSuffix")
b.messageCreate(s, (*discordgo.MessageCreate)(m))
}
}
diff --git a/bridge/helper/helper.go b/bridge/helper/helper.go
index bfa7d82..dab2bb4 100644
--- a/bridge/helper/helper.go
+++ b/bridge/helper/helper.go
@@ -447 +447 @@ func SplitStringLength(input string, length int) string {
a := []rune(input)
str := ""
for i, r := range a {
- str = str + string(r)
+ str += string(r)
if i > 0 && (i+1)%length == 0 {
str += "\n"
}
diff --git a/bridge/irc/irc.go b/bridge/irc/irc.go
index 25f6bee..0702575 100644
--- a/bridge/irc/irc.go
+++ b/bridge/irc/irc.go
@@ -638 +637 @@ func New(cfg *bridge.Config) bridge.Bridger {
}
func (b *Birc) Command(msg *config.Message) string {
- switch msg.Text {
- case "!users":
+ if msg.Text == "!users" {
b.i.Handlers.Add(girc.RPL_NAMREPLY, b.storeNames)
b.i.Handlers.Add(girc.RPL_ENDOFNAMES, b.endNames)
b.i.Cmd.SendRaw("NAMES " + msg.Channel)
@@ -2377 +2367 @@ func (b *Birc) Send(msg config.Message) (string, error) {
}
if len(b.Local) < b.MessageQueue {
if len(b.Local) == b.MessageQueue-1 {
- text = text + " <message clipped>"
+ text += " <message clipped>"
}
b.Local <- config.Message{Text: text, Username: msg.Username, Channel: msg.Channel, Event: msg.Event}
} else {
diff --git a/bridge/matrix/matrix.go b/bridge/matrix/matrix.go
index 18bc557..aaf1932 100644
--- a/bridge/matrix/matrix.go
+++ b/bridge/matrix/matrix.go
@@ -23411 +23411 @@ func (b *Bmatrix) handleDownloadFile(rmsg *config.Message, content map[string]in
if msgtype == "m.image" {
mext, _ := mime.ExtensionsByType(mtype)
if len(mext) > 0 {
- name = name + mext[0]
+ name += mext[0]
}
} else {
// just a default .png extension if we don't have mime info
- name = name + ".png"
+ name += ".png"
}
}
diff --git a/bridge/telegram/telegram.go b/bridge/telegram/telegram.go
index 93cc82f..43d68ed 100644
--- a/bridge/telegram/telegram.go
+++ b/bridge/telegram/telegram.go
@@ -3037 +3037 @@ func (b *Btelegram) handleDownload(message *tgbotapi.Message, rmsg *config.Messa
urlPart := strings.Split(url, "/")
name = urlPart[len(urlPart)-1]
if !strings.HasSuffix(name, ".webp") {
- name = name + ".webp"
+ name += ".webp"
}
text = " " + url
}
@@ -3387 +3387 @@ func (b *Btelegram) handleDownload(message *tgbotapi.Message, rmsg *config.Messa
name = urlPart[len(urlPart)-1]
text = " " + url
if !strings.HasSuffix(name, ".ogg") {
- name = name + ".ogg"
+ name += ".ogg"
}
}
if message.Audio != nil {
@@ -3567 +3567 @@ func (b *Btelegram) handleDownload(message *tgbotapi.Message, rmsg *config.Messa
// use the URL instead of native upload
if b.GetBool("UseInsecureURL") {
b.Log.Debugf("Setting message text to :%s", text)
- rmsg.Text = rmsg.Text + text
+ rmsg.Text += text
return nil
}
// if we have a file attached, download it (in memory) and put a pointer to it in msg.Extra
diff --git a/gateway/gateway.go b/gateway/gateway.go
index e699251..d4c8465 100644
--- a/gateway/gateway.go
+++ b/gateway/gateway.go
@@ -4817 +4817 @@ func (gw *Gateway) handleFiles(msg *config.Message) {
ext := filepath.Ext(fi.Name)
fi.Name = fi.Name[0 : len(fi.Name)-len(ext)]
fi.Name = reg.ReplaceAllString(fi.Name, "_")
- fi.Name = fi.Name + ext
+ fi.Name += ext
sha1sum := fmt.Sprintf("%x", sha1.Sum(*fi.Data))[:8]
