commit b745562202e72c096d0c4121bbf0fe60e007adec
Author: Wim <wim@42.be>
Date: Wed Mar 27 22:54:18 2019 +0000
Ignore message_replied and hidden messages (slack). Fixes #709 (#779)
diff --git a/bridge/slack/handlers.go b/bridge/slack/handlers.go
index b756393..8710263 100644
--- a/bridge/slack/handlers.go
+++ b/bridge/slack/handlers.go
@@ -13012 +13018 @@ func (b *Bslack) skipMessageEvent(ev *slack.MessageEvent) bool {
return true
}
- // It seems ev.SubMessage.Edited == nil when slack unfurls.
- // Do not forward these messages. See Github issue #266.
- if ev.SubMessage != nil &&
- ev.SubMessage.ThreadTimestamp != ev.SubMessage.Timestamp &&
- ev.SubMessage.Edited == nil {
- return true
+ if ev.SubMessage != nil {
+ // It seems ev.SubMessage.Edited == nil when slack unfurls.
+ // Do not forward these messages. See Github issue #266.
+ if ev.SubMessage.ThreadTimestamp != ev.SubMessage.Timestamp &&
+ ev.SubMessage.Edited == nil {
+ return true
+ }
+ // see hidden subtypes at https://api.slack.com/events/message
+ // these messages are sent when we add a message to a thread #709
+ if ev.SubType == "message_replied" && ev.Hidden {
+ return true
+ }
}
if len(ev.Files) > 0 {
