commit 6ab9156b0dc22f4d1f1e38f3542bcc6ff8883b7a
Author: Patrick Connolly <patrick.c.connolly@gmail.com>
Date: Thu Oct 25 03:12:20 2018 +0000
Fix bridge no longer POSTing username and avatar (slack) (#536)
* Fixed pointer/reference issue in populateUsers. [#536]
* Accepted codestyle suggestion.
* Update bridge/slack/helpers.go
Co-Authored-By: patcon <patrick.c.connolly@gmail.com>
* Update helpers.go
diff --git a/bridge/slack/helpers.go b/bridge/slack/helpers.go
index 18dded3..8508d15 100644
--- a/bridge/slack/helpers.go
+++ b/bridge/slack/helpers.go
@@ -658 +6510 @@ func (b *Bslack) populateUsers() {
}
newUsers := map[string]*slack.User{}
- for _, user := range users {
- newUsers[user.ID] = &user
+ for i := range users {
+ // Use array index for pointer, not the copy
+ // See: https://stackoverflow.com/a/29498133/504018
+ newUsers[users[i].ID] = &users[i]
}
b.usersMutex.Lock()
